Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(share/p2p): extend proto with ignoreMaxNamespace field #2450

Closed

Conversation

vgonkivs
Copy link
Member

Overview

Closes #2427

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added kind:feat Attached to feature PRs kind:break! Attached to breaking PRs shrex For issues and PRs related to shrex protocol labels Jul 11, 2023
@vgonkivs vgonkivs self-assigned this Jul 11, 2023
@Wondertan
Copy link
Member

#2427 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #2450 (4dad051) into main (beaf6db) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
- Coverage   53.28%   53.04%   -0.24%     
==========================================
  Files         156      156              
  Lines        9915     9908       -7     
==========================================
- Hits         5283     5256      -27     
- Misses       4179     4196      +17     
- Partials      453      456       +3     
Impacted Files Coverage Δ
share/p2p/shrexnd/client.go 45.52% <0.00%> (ø)
share/p2p/shrexnd/params.go 12.50% <ø> (ø)
share/p2p/shrexnd/server.go 52.66% <0.00%> (-0.36%) ⬇️

... and 7 files with indirect coverage changes

@vgonkivs
Copy link
Member Author

@Wondertan , #2427 (comment)

@vgonkivs vgonkivs closed this Jul 19, 2023
@vgonkivs
Copy link
Member Author

This PR should be closed as we have implemented own nmt proto definition in the nmt repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:break! Attached to breaking PRs kind:feat Attached to feature PRs shrex For issues and PRs related to shrex protocol
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Unify the representation of jsonProof and pb.Proof
3 participants