Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share/shwap/getters): set span err only if all getters truly failed, otherwise just record err in span for single getter failure #4130

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renaynay
Copy link
Member

Span records all getters failed if only 1 getter failed but get op succeeds on 2nd.

…ed, otherwise record err in span for single getter failure, not top level
@renaynay renaynay added the kind:fix Attached to bug-fixing PRs label Feb 18, 2025
@renaynay renaynay self-assigned this Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.05%. Comparing base (2469e7a) to head (25ededc).
Report is 443 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4130      +/-   ##
==========================================
+ Coverage   44.83%   45.05%   +0.21%     
==========================================
  Files         265      308      +43     
  Lines       14620    22550    +7930     
==========================================
+ Hits         6555    10160    +3605     
- Misses       7313    11302    +3989     
- Partials      752     1088     +336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay renaynay marked this pull request as draft February 18, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants