Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libp2p version #862

Merged
merged 5 commits into from
Jun 28, 2022
Merged

bump libp2p version #862

merged 5 commits into from
Jun 28, 2022

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jun 27, 2022 •
edited by Wondertan
Loading

Updated libp2p and all related libraries to latest versions.

Closes #306

@vgonkivs vgonkivs self-assigned this Jun 27, 2022
@vgonkivs vgonkivs added the kind:deps Pull requests that update a dependency file label Jun 27, 2022
Wondertan
Wondertan requested changes Jun 27, 2022
View reviewed changes
header/store/store.go Outdated Show resolved Hide resolved
@Wondertan
Copy link
Member

Ideally, we would split this PR in:

  • Update go-datastore, which passes the contexts as the interface now requires
  • Update go-cid with supporting changes
  • Update libp2p and all the protocols

Wondertan
Wondertan reviewed Jun 27, 2022
View reviewed changes
ipld/plugin/nmt.go Outdated Show resolved Hide resolved
@Wondertan
Copy link
Member

Closes #306 and #656

@Wondertan
Copy link
Member

Wondertan commented Jun 27, 2022 •
edited
Loading

Pls also run go list -u -m -json all | go-mod-outdated -update -direct to check all the outdated deps we have and ensure all the libp2p ones are updated(besides pubsub, because it requires some additional treatments as we have a fork). The https://github.com/psampaz/go-mod-outdated tool

Wondertan
Wondertan reviewed Jun 27, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Jun 27, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@Wondertan Wondertan mentioned this pull request Jun 27, 2022
Closed
@vgonkivs vgonkivs force-pushed the bump_libp2p_version branch from 6b57965 to 5220f85 Compare June 28, 2022 11:00
renaynay
renaynay approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks @vgonkivs 🚀

Two minor comments, but otherwise LGTM

header/store/store.go Outdated Show resolved Hide resolved
service/share/full_availability.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs requested a review from Wondertan June 28, 2022 13:02
Wondertan
Wondertan requested changes Jun 28, 2022
View reviewed changes
header/store/store.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the bump_libp2p_version branch from 671cf3b to e0bc1fd Compare June 28, 2022 13:21
@Wondertan Wondertan mentioned this pull request Jun 28, 2022
Merged
@vgonkivs vgonkivs requested a review from Wondertan June 28, 2022 13:50
@vgonkivs vgonkivs force-pushed the bump_libp2p_version branch from 949c751 to d2e69c3 Compare June 28, 2022 14:03
@Wondertan
Copy link
Member

Thanks again

@vgonkivs vgonkivs merged commit 2da986c into celestiaorg:main Jun 28, 2022
@liamsi liamsi changed the title bump lib2p version bump libp2p version Jun 28, 2022
@vgonkivs vgonkivs deleted the bump_libp2p_version branch January 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@liamsi liamsi Awaiting requested review from liamsi

Assignees

@vgonkivs vgonkivs

Labels
kind:deps Pull requests that update a dependency file
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocker for updating libp2p/ipfs libs
3 participants
@vgonkivs @Wondertan @renaynay