Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint and build issues #22

Merged
merged 2 commits into from
Jun 30, 2023
Merged

fix lint and build issues #22

merged 2 commits into from
Jun 30, 2023

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Jun 29, 2023 •
edited
Loading

Overview

This PR fixes build issues. local-celestia-devnet is used for unit tests.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybal tzdybal requested a review from tuxcanfly June 29, 2023 22:48
@tzdybal tzdybal added the enhancement New feature or request label Jun 29, 2023
@tzdybal tzdybal force-pushed the tzdybal/fix_gh_actions branch from 52f5aed to 3217952 Compare June 29, 2023 22:56
@tzdybal tzdybal marked this pull request as ready for review June 29, 2023 23:02
tuxcanfly
tuxcanfly previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

client_test.go Outdated Show resolved Hide resolved
tuxcanfly
tuxcanfly reviewed Jun 29, 2023
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
@tuxcanfly tuxcanfly mentioned this pull request Jun 30, 2023
Merged
5 tasks
@tzdybal tzdybal enabled auto-merge (squash) June 30, 2023 19:07
@tzdybal tzdybal requested a review from tuxcanfly June 30, 2023 19:07
tuxcanfly
tuxcanfly approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@tzdybal tzdybal merged commit ca6118a into main Jun 30, 2023
@tzdybal tzdybal deleted the tzdybal/fix_gh_actions branch June 30, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S1nus S1nus S1nus approved these changes

@tuxcanfly tuxcanfly tuxcanfly approved these changes

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya

@nashqueue nashqueue Awaiting requested review from nashqueue

Assignees

@tzdybal tzdybal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzdybal @tuxcanfly @S1nus