-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add otel collector section for mocha, and headings. also linting and fix internal link #1400
Conversation
WalkthroughThe recent updates focus on refining the Celestia Foundation Delegation Program, specifically targeting the improvement of validator participation guidelines and the node metrics monitoring process. These changes aim to enhance clarity, fairness, and performance in validator operations, while also providing detailed instructions for integrating metrics into Celestia nodes, ensuring better network monitoring and stability. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (2)
- community/foundation-delegation-program.md (3 hunks)
- nodes/celestia-node-metrics.md (2 hunks)
Additional comments: 6
nodes/celestia-node-metrics.md (3)
- 25-33: Ensure the placeholder URL for the metrics endpoint in the Mainnet Beta example is replaced with the correct URL once available.
- 51-52: Confirm the placeholder
<your-mocha-metrics-endpoint>
is intended for users to replace with their specific endpoint URL.- 31-33: Verify the ADR link is accessible and points to the correct document.
community/foundation-delegation-program.md (3)
- 7-15: Ensure the objectives of the program are aligned with the Celestia Foundation's mission and accurately reflect the program's goals.
- 107-114: Review the undelegation criteria for clarity and ensure they are consistent with the Celestia Foundation's policies and legal requirements.
- 171-172: Confirm the frequency and content of the feedback form align with the program's objectives for continuous improvement.
Overview
This PR adds a section to otel collector for mocha. Needs to be updated with:
the correct URL for otel collectorusing placeholder in meantime to get these changes inThere is a known issue with the preview link in comment from celestia-bot below (#1195). So Use this link for the preview of the relevant section
This PR also replaces https://github.com/celestiaorg/docs/pull/1398/files, switching to internal links for links internal pages on the site.
Separately, I think the linting should be in CI again IMO it is a PITA to deal with locally, opened up #1399 to track this issue. Update here, I'll be using a git commit hook instead of husky
Checklist
Summary by CodeRabbit