Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add validator migration guide and networks list table #1854

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redwest88
Copy link
Contributor

@redwest88 redwest88 commented Jan 9, 2025

Overview

This PR adds two sections to the docs, specifically to the validator-node.md file:

  1. Validator Migration Guide: Detailed guide for migrating a validator to a new machine.
  2. Networks List Table: A table listing the mainnet, testnet, and devnet, along with their chain IDs and CLI usage. This table appears to have been intended but is currently missing from the content.

Summary by CodeRabbit

  • Documentation
    • Added comprehensive guide for migrating a validator node to a new machine
    • Included step-by-step instructions for safe validator transfer
    • Added new FAQ entry addressing block version mismatch errors

Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

Walkthrough

The pull request enhances the validator node documentation by introducing a comprehensive guide for migrating a validator to a new machine. The new section provides a detailed, step-by-step process that covers setting up a new consensus node, stopping the old validator, securely transferring the validator key, and restarting the validator. Additionally, a new FAQ entry is added to help users troubleshoot a specific block version mismatch error, improving the overall documentation's utility and user guidance.

Changes

File Change Summary
how-to-guides/validator-node.md - Added new section "Migrating a validator to another machine"
- Included 4-step migration process
- Added new FAQ entry for block version error troubleshooting

Poem

🐰 Validator's Dance, a Rabbit's Refrain

From old server to new, with keys in hand,
Migrate with care, on a digital strand
Sync, stop, transfer, and restart with might
No double-signing to cause validator's fright!
A smooth transition, blockchain's delight 🌐

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
how-to-guides/validator-node.md (2)

275-283: Clarify the service name placeholder

The <SERVICE_NAME> placeholder needs more context. Consider adding a note explaining that this should be replaced with the actual SystemD service name (e.g., celestia-appd.service) that was set up during the initial validator configuration.


293-297: Consider additional backup recommendations

While backing up priv_validator_key.json is crucial, consider recommending backup of additional important files:

  • config/node_key.json for node identity
  • data/priv_validator_state.json for validator state
  • config/client.toml for custom configurations
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a089fbc and ef502eb.

📒 Files selected for processing (1)
  • how-to-guides/validator-node.md (2 hunks)
🔇 Additional comments (2)
how-to-guides/validator-node.md (2)

184-189: Well-structured networks table!

The table provides clear and accurate information about available networks, with proper documentation links and correct chain IDs.


251-253: Excellent warning about double signing risks!

The note effectively emphasizes the critical nature of the migration process and potential consequences of mistakes.

Comment on lines +307 to +311
If everything checks out, you can now restart the new node with the updated validator key:

```bash
sudo systemctl restart <SERVICE_NAME>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add verification steps after migration

Consider adding commands to verify the validator is operating correctly after migration:

  • Check validator status and voting power
  • Verify block signing
  • Monitor for any missed blocks

Example verification commands to add:

+# Check validator status
+celestia-appd query staking validator $(celestia-appd keys show $VALIDATOR_WALLET --bech val -a)
+
+# Monitor block signing
+celestia-appd query slashing signing-info $(celestia-appd tendermint show-validator)

Committable suggestion skipped: line range outside the PR's diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant