Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rbac #129

Merged
merged 4 commits into from
Jul 7, 2023
Merged

feat: add rbac #129

merged 4 commits into from
Jul 7, 2023

Conversation

smuu
Copy link
Member

@smuu smuu commented Jul 3, 2023 •
edited
Loading

TODO
Preview Give feedback

Tested on branch https://github.com/celestiaorg/knuu-example/tree/feature/add-rbac

Resolves #119

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 requested a review from a team July 3, 2023 13:31
tty47
tty47 reviewed Jul 3, 2023
View reviewed changes
pkg/knuu/instance.go Outdated Show resolved Hide resolved
Bidon15
Bidon15 reviewed Jul 3, 2023
View reviewed changes
pkg/knuu/instance_helper.go Outdated Show resolved Hide resolved
pkg/knuu/instance_helper.go Show resolved Hide resolved
tty47
tty47 reviewed Jul 3, 2023
View reviewed changes
pkg/knuu/instance_helper.go Outdated Show resolved Hide resolved
@smuu
Copy link
Member Author

smuu commented Jul 3, 2023

This PR needs some more work. I will put it in draft mode until done.

@smuu smuu marked this pull request as draft July 3, 2023 13:59
@smuu smuu force-pushed the feature/add-rbac branch from 9cf5f22 to e831cfd Compare July 5, 2023 13:53
@smuu smuu marked this pull request as ready for review July 6, 2023 10:41
@smuu smuu requested a review from Bidon15 July 6, 2023 12:20
Bidon15
Bidon15 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@smuu smuu force-pushed the feature/add-rbac branch from 355c2ee to 880b4fe Compare July 6, 2023 12:28
@smuu smuu merged commit 55b8214 into main Jul 7, 2023
@smuu smuu deleted the feature/add-rbac branch July 7, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 left review comments

@Bidon15 Bidon15 Bidon15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Celestia DevOps/Testing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the possibility of managing RBAC
3 participants
@smuu @Bidon15 @tty47