Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(naming): update name in the instance test #369

Merged
merged 5 commits into from
May 23, 2024

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented May 23, 2024

the idea of this PR is to fix #368 , by updating the instance name

@tty47 tty47 self-assigned this May 23, 2024
@celestia-bot celestia-bot requested review from MSevey, smuu and sysrex May 23, 2024 07:44
@tty47 tty47 added bug Something isn't working knuu fix Fix labels May 23, 2024
@tty47
Copy link
Contributor Author

tty47 commented May 23, 2024

--- PASS: TestExternalFile (14.67s)

found another one:

=== NAME  TestFile
    file_test.go:63: Error getting IP 'error deploying service for instance 'web-ed745da1': error deploying service 'web-ed745da1': error creating service web-ed745da1: services "web-ed745da1" already exists':
    file_test.go:56: 
        	Error Trace:	/home/runner/work/knuu/knuu/e2e/basic/file_test.go:56
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1175
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1353
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1683
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:626
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1005
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1089
        	            				/home/runner/work/knuu/knuu/e2e/basic/file_test.go:63
        	Error:      	Received unexpected error:
        	            	destroying is only allowed in state 'Started' or 'Destroyed'. Current state is 'Committed
        	Test:       	TestFile
--- FAIL: TestFile (5.29s)

@tty47 tty47 merged commit 0cccd1f into main May 23, 2024
3 of 4 checks passed
@tty47 tty47 deleted the jose/fix-test-rename-instance branch May 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Fix knuu
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename instance name in the test TestExternalFile
2 participants