Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checks that all the arguments of VerifyNamespace conform to the same namespace hash format #179

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

staheri14
Copy link
Collaborator

@staheri14 staheri14 commented Apr 18, 2023

Overview

Closes #141

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 changed the title Resolve panic verifyleafhashes feat: checks that all the arguments of VerifyNamespace conform to the same namespace hash format Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #179 (7dd0a29) into master (6cb81d0) will decrease coverage by 1.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   95.41%   94.04%   -1.38%     
==========================================
  Files           5        5              
  Lines         523      537      +14     
==========================================
+ Hits          499      505       +6     
- Misses         14       18       +4     
- Partials       10       14       +4     
Impacted Files Coverage Δ
proof.go 87.02% <100.00%> (-5.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@staheri14 staheri14 self-assigned this Apr 18, 2023
@staheri14 staheri14 added the enhancement New feature or request label Apr 18, 2023
@staheri14 staheri14 marked this pull request as ready for review April 19, 2023 00:08
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@staheri14 staheri14 merged commit 0c70c1b into master Apr 19, 2023
@staheri14 staheri14 deleted the resolve-panic-verifyleafhashes branch April 19, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerifyLeafHashes can panic in the completeness check if proof.nodes are not namespaced
3 participants