-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: handles empty proofs in validateLeafHash and VerifyInclusion #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 94.14% 95.66% +1.51%
==========================================
Files 5 5
Lines 547 554 +7
==========================================
+ Hits 515 530 +15
+ Misses 18 14 -4
+ Partials 14 10 -4
|
staheri14
changed the title
feat: handles empty proofs in validateLeafHash and VerifyInclusion
feat!: handles empty proofs in validateLeafHash and VerifyInclusion
Apr 27, 2023
rootulp
approved these changes
Apr 28, 2023
evan-forbes
approved these changes
May 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #140
The changes made in this PR are considered to be breaking, as they modify the behavior of
VerifyInclusion
. In the prior version, theVerifyInclusion
function would returnfalse
for the first test case named "valid empty proof and leaves == empty." of theTestVerifyInclusion_EmptyProofs
suite. However, with the changes implemented, an empty proof for an empty set of leaves is now considered a valid proof. As a result,VerifyInclusion
now returnstrue
.cc: @liamsi
Checklist