-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: incorporates tests for short absence proof verification #217
Conversation
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 5 5
Lines 601 601
=======================================
Hits 563 563
Misses 21 21
Partials 17 17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clearly written tests 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Callum's comment, really well written and clear tests. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
Overview
After investigating the current implementation, verified that the nmt library is capable of verifying short absence proofs. This PR contains the necessary tests to demonstrate and test this capability.
In line with #210
Checklist