Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for subtree root verification #260
feat: add support for subtree root verification #260
Changes from 2 commits
51df389
4daae42
4ba85fe
12b62f1
ad2f71d
82d1886
cff80b2
47d2113
661d059
a81b748
a68a69f
9d92a94
12ec563
3ad98af
70bc2b0
a580bac
680faca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 663 in nmt.go
Codecov / codecov/patch
nmt.go#L663
Check warning on line 667 in nmt.go
Codecov / codecov/patch
nmt.go#L667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates the state of the original tree
n
, can we create another instance of the tree instead similar to other test cases i.e.,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the problem with updating the original tree with a root in a test? that would make the other tests not recalculate it which is good, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason that this test case errors out is that the the range of the proof is larger than the size of the tree, hence, the comment
tree leaves are not a power of 2
does not indicate why an error is expected, right?To my understanding, the correct behaviour of this specific function i.e,
ComputeSubtreeRoot
does not require the tree to be power of two.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on: #260 (comment)