Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

fuzz: return nil if len(keys) is zero #55

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

odeke-em
Copy link
Contributor

Fixes a divide by zero exception which resulted
from a modulo operation using keys that were non-existent.
oss-fuzz reported a crash

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37182

but that was a fault in the fuzzing code, and not in smt.

Fixes a divide by zero exception which resulted
from a modulo operation using keys that were non-existent.
oss-fuzz reported a crash

    https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37182

but that was a fault in the fuzzing code, and not in smt.
@odeke-em
Copy link
Contributor Author

/cc @cuonglm @liamsi

@codecov-commenter
Copy link

Codecov Report

Merging #55 (23d38e6) into master (a8b51d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files           6        6           
  Lines         468      468           
=======================================
  Hits          401      401           
  Misses         39       39           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f62d6...23d38e6. Read the comment docs.

@adlerjohn adlerjohn added the bug Something isn't working label Aug 15, 2021
@adlerjohn adlerjohn merged commit a99c0f5 into celestiaorg:master Aug 15, 2021
@odeke-em
Copy link
Contributor Author

Thank you @adlerjohn and @cuonglm for the review!

@odeke-em odeke-em deleted the fix-divide-by-zero-in-fuzzer branch August 15, 2021 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants