Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#224): 修复importx导致的HMR失效问题，关闭缓存 #225

Merged
merged 6 commits into from
Feb 14, 2025
Merged

fix(#224): 修复importx导致的HMR失效问题，关闭缓存 #225

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca1ce79
fix(#224): 修复importx导致的HMR失效问题，关闭缓存
nailiable Feb 13, 2025
a4c6d0f
fix: 在HMR时不使用importx，直接使用createRequire
nailiable Feb 14, 2025
7380c6e
fix: HookExecutor去除importx的cache
nailiable Feb 14, 2025
45f8852
fix: HMR改回使用importx，才能使用ESM
nailiable Feb 14, 2025
74c0030
chore: 还原示例文件
nailiable Feb 14, 2025
73e0f44
fix: 改回使用require导入entry模块
nailiable Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dev-packages/cli-service/src/hooks/start-dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ async function attachBackendServer(ctx: ConfigurationContext, callback: Callback
while (true) {
if (fs.existsSync(entryPath)) {
mountRuntimeModuleCaches();
return importx(entryPath, __filename);
return importx(entryPath, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我理解不需要 importx，因为这里的文件都是编译过的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那就直接改成createRequire🤔

parentURL: __filename,
cache: false,
});
}
await delay(200);
}
Expand Down