Avoid SSLSocket leaks by setting sync_close by default

[zanker]

@tarcieri

[digitalextremist]

You don't need the delegator if you're calling sync_close on @socket directly.

[zanker]

The delegator is in case people want to override the behavior primarily. I think the odds of someone wanting to do that is nil, but people do strange things.

[tarcieri]

I'd like for Celluloid::IO::SSLSocket to be as close to a duck type of OpenSSL::SSL::SSLSocket as possible, and that includes delegating this method.

[digitalextremist]

My bad on confusing the intent here, focusing only on function. Clear to merge then once the blizzard of tests is subdued to something sane.

[zanker]

No problem! I agree on it being ugly. I hate the sync_close setter but Ruby made it default off so :(

Sent from my iPhone

On Apr 6, 2015, at 11:43, digitalextremist [email protected] wrote:

In lib/celluloid/io/ssl_socket.rb:

   def initialize(io, ctx = OpenSSL::SSL::SSLContext.new)
     super()
     @context = ctx
     @socket = OpenSSL::SSL::SSLSocket.new(::IO.try_convert(io), @context)

•    @socket.sync_close = true if @socket.respond_to?(:sync_close=)
  

  My bad on confusing the intent here, focusing only on function. Clear to merge then once the blizzard of tests is subdued to something sane.

—
Reply to this email directly or view it on GitHub.

[tarcieri]

Oh my, the build failures 😢

They all seem unrelated at least, but...

/cc @digitalextremist

[digitalextremist]

Uhhh. #134?

[digitalextremist]

Yeah. These are rspec syntax/behavior failures.

[zanker]

Sorry, not clear but what's the problem? Does #134 block until this goes green?

[digitalextremist]

There's an rspec compatibility issue. I'll try to remedy it before #134 when I'm back from lunch.

[tarcieri]

I wouldn't be opposed to landing this despite the spec failures

[digitalextremist]

Yeah, I'm just going to merge this now and fiddle with tests separately.

[ixti]

@digitalextremist transpec helps a lot to update specs...

[digitalextremist]

That's very helpful @ixti, thank you!

@e2 is this what you've been doing? :)

[digitalextremist]

[ haha, now that all the tests are current :) ]

[e2]

@digitalextremist - yeah, life would be hard without transpec. There are a few tricks, though (for outdated projects):

1. first, update to RSpec 2.99, which is highly compatible with other 2.x versions + run tests
2. update the spec/spec_helper config (remove stuff mostly) so tests run
3. transpec + commit (best to temporarily add to Gemfile - best to use with Bundler)
4. update to RSpec 3.2
5. transpec again (will be different)
6. remove transpec and update spec_helper with new RSpec features