Fix PrecompileOverride bug (#11269)

* -- duplicated function * general L2 tests * ++ L1 GovernanceTest_resetHotfix * ++ remaining tests * debuging * more debug logs * more debug * ++ debugs * suppress other tests * ++ more debug * test with previous release * force CI test * calling election function ditrectly * migration debug * min elected during test * ++ logs * stringify * ++ return value * revert debug changes * revert debug comments * reenable all ci test * revert to 1 sec sleep
celo-org · Feb 3, 2025 · 46e1bcc · 46e1bcc
1 parent ad82d50
commit 46e1bcc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/celotool/src/e2e-tests/governance_tests.ts b/packages/celotool/src/e2e-tests/governance_tests.ts
@@ -310,7 +310,7 @@ describe('governance tests', () => {
     if (myceloAddress === groupAddress) {
       return '0x' + generatePrivateKey(mnemonic, AccountType.VALIDATOR_GROUP, 0)
     }
-    // Otherwise, the validator group key is encoded in its name (see 25_elect_validators.ts)
+    // Otherwise, the validator group key is encoded in its name (see 30_elect_validators.ts)
     const name = await accounts.methods.getName(groupAddress).call()
     const encryptedKeystore64 = name.split(' ')[1]
     const encryptedKeystore = JSON.parse(Buffer.from(encryptedKeystore64, 'base64').toString())

diff --git a/packages/protocol/contracts/common/PrecompilesOverride.sol b/packages/protocol/contracts/common/PrecompilesOverride.sol
@@ -42,7 +42,7 @@ contract PrecompilesOverride is UsingPrecompiles, UsingRegistry {
     if (isL2()) {
       return getEpochManager().getElectedSignerByIndex(index);
     } else {
-      super.validatorSignerAddressFromCurrentSet(index);
+      return super.validatorSignerAddressFromCurrentSet(index);
     }
   }
 

diff --git a/packages/protocol/package.json b/packages/protocol/package.json
@@ -152,4 +152,4 @@
     "typechain-target-ethers-v5": "^5.0.1",
     "yargs": "^14.0.0"
   }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -152,4 +152,4 @@ @@
         "typechain-target-ethers-v5": "^5.0.1",
         "yargs": "^14.0.0"
       }
-    }
+    }