Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Sorry something went wrong is shown when user taps on Licenses option from the setting #1459

Closed
Lss-Ankit opened this issue Oct 24, 2019 · 8 comments · Fixed by #4589 or #4927
Closed

[iOS] Sorry something went wrong is shown when user taps on Licenses option from the setting #1459

Lss-Ankit opened this issue Oct 24, 2019 · 8 comments · Fixed by #4589 or #4927
Assignees
@jeanregisser
Labels
bug Something isn't working ios Priority: P2 Major qa wallet

Comments

@Lss-Ankit
Copy link

Frequency: 100%
App version: Test Flight build v1.5.0(10)
Repro on: iPod Touch 6 (12.4), iPad 5th Gen (13.1)
Testing Account: 680 208 0265/Backup Kay

Repro Steps:

  1. Launch the app.
  2. Tap on the Cog icon.
  3. Tap on the “Licenses” option.
  4. Observe.

Impact: User is blocked to see licenses of the app.
Investigation: Error “Something went wrong” is shown when users navigate to the Licenses screen.
Current Behavior: App get crashed
Expected Behavior: Users should be able to see the licenses of the app.
Attachment: AppCrash_Licence_Quit.mp4 (Bug observe at 11 sec)
@Lss-Ankit Lss-Ankit added bug Something isn't working ios Priority: P2 Major qa wallet labels Oct 24, 2019
@Lss-Ankit
Copy link
Author

Note: As per this ticket #1424 in iOS, we can not restart the app hence user force out from the app by tapping on the "Quit" button.

jeanregisser added a commit that referenced this issue Oct 25, 2019
@jeanregisser
Fix error when opening the license screen on iOS, #1459
4516def
@jmrossy jmrossy mentioned this issue Nov 6, 2019
Closed
@nityas
Copy link
Contributor

nityas commented Nov 12, 2019 •
edited
Loading

closing as a duplicate of #1424

@nityas nityas closed this as completed Nov 12, 2019
@Lss-Ankit
Copy link
Author

@nityas I do get your point that this ticket is related to #1424 where user Exits the iOS app when tapped on the Quit button.
However, as per the given title in this ticket, my main concern was the Error message Shown "Something went wrong". Which is blocking the user to view the License data of the App.
Hence, as per me this bug is not a duplicate to #1424 and should be in open state.
Please correct me if my understanding is different.

Also, I have verified this ticket with the latest iOS build v1.5.1 (14) and Error loading page is shown when user taps on the "Licenses" option.
Attachment: iOS_LicensesIssue.png
iOS_LicensesIssue

@Lss-Ankit
Copy link
Author

@jeanregisser Verified with IOS test flight build v1.6.1 (23) and found that issue is still reproduced.

  • "Error loading page" is shown when user taps on Licenses option from the setting

Attachment: IOS_Licenses_ErrorScreen.png
IOS_Licenses_ErrorScreen

@Lss-Ankit Lss-Ankit reopened this Mar 4, 2020
@Lss-Ankit
Copy link
Author

Verified with latest IOS test flight Valora build v1.0.0(6) and observed that issue is reintroduced

  • "Error loading page" is shown when user taps on Licenses option from the setting
  • Device Used: iPhone 6(12.4.7)
    77091

@jeanregisser jeanregisser mentioned this issue Jul 31, 2020
Merged
@mergify mergify bot closed this as completed in #4589 Aug 1, 2020
mergify bot pushed a commit that referenced this issue Aug 1, 2020
@jeanregisser
[Wallet] Fix empty license page on iOS (#4589)
c51e8e6 
### Description

Fix empty license page on iOS.

Note: The data is just text, so could look nicer in HTML form, but is good enough for now 😉 

### Other changes

None

### Tested

<img src="https://user-images.githubusercontent.com/57791/89050430-0b16a080-d353-11ea-9bf3-b79fb183c8ad.png" width="50%" />

### Related issues

- Epic #4415
- #4560
- Fixes #1459
- Fixed #626

### Backwards compatibility

Yes
@Lss-Ankit
Copy link
Author

@jeanregisser Verified with Latest test flight valora build v1.0.0 (11) and found that Blank screen is shown when user taps on Licenses option from setting.

Note: Issue is not repro on Android Valora build v1.0.0 (12)

@Lss-Ankit Lss-Ankit reopened this Aug 22, 2020
@Lss-Ankit
Copy link
Author

@annakaz i have Verified this issue with Latest test flight valora build v1.0.0 (15) and found that Blank screen is shown when user taps on Licenses option from setting.
Device: iPhone 6+(12.4.5)
Note: Issue is not repro on Android Valora build v1.0.0 (12)

@jeanregisser jeanregisser self-assigned this Aug 28, 2020
@jeanregisser jeanregisser mentioned this issue Sep 1, 2020
Merged
@mergify mergify bot closed this as completed in #4927 Sep 2, 2020
mergify bot pushed a commit that referenced this issue Sep 2, 2020
@jeanregisser
[Wallet] Fix blank license screen on iOS (take 2) (#4927)
4fff39d 
### Description

Without `originWhitelist={['*']}` set, we were getting the following error on iOS release builds: `-canOpenURL: failed for URL: "file:///...` and the screen would remain blank.

I thought I had tested this on a release build when I worked on this same issue for #4589 🤦 

### Other changes

- Upgraded `react-native-webview`, (might help for #4735)

### Tested

License screen displays correctly on iOS release builds.

### Related issues

- Fixes #1459

### Backwards compatibility

Yes
@Lss-Ankit
Copy link
Author

I have verified this issue using using iOS test flight build v1.1.0(21) and found issue is fixed
Device : iPhone 6+ (12.4.5),iphone 7+ (13.3.1)

ewilz pushed a commit to ewilz/celo-monorepo that referenced this issue Sep 29, 2020
@jeanregisser @ewilz
[Wallet] Fix blank license screen on iOS (take 2) (celo-org#4927)
40de336 
### Description

Without `originWhitelist={['*']}` set, we were getting the following error on iOS release builds: `-canOpenURL: failed for URL: "file:///...` and the screen would remain blank.

I thought I had tested this on a release build when I worked on this same issue for celo-org#4589 🤦 

### Other changes

- Upgraded `react-native-webview`, (might help for #4735)

### Tested

License screen displays correctly on iOS release builds.

### Related issues

- Fixes celo-org#1459

### Backwards compatibility

Yes
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
@snyk-bot snyk-bot mentioned this issue Apr 12, 2022
Open
This was referenced Aug 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 8, 2022
Open
This was referenced Oct 6, 2022
Open
Open
This was referenced Apr 24, 2023
Open
Open
Open
@lili2311 lili2311 mentioned this issue Aug 15, 2023
Open
@leojoy95 leojoy95 mentioned this issue May 16, 2024
Open
@leojoy95 leojoy95 mentioned this issue Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanregisser jeanregisser

Labels
bug Something isn't working ios Priority: P2 Major qa wallet
Projects
None yet
Milestone
No milestone
3 participants
@jeanregisser @nityas @Lss-Ankit