-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User phone numbers and country should be input automatically #654
Comments
To autocomplete phone number (not fully sure this includes country code), the app should have Alternative option to complete only country code will be using an API to get the phone's public IP, then use a geoIP library and then convert that to a phone country code. Example of API to get IP: https://github.com/sindresorhus/ipify |
My feeling is that heavy permissions is not worth the feature. |
@martinvol the link above in the issue description has the API to do it without permission - creating a hint request (https://developers.google.com/identity/sms-retriever/request) |
Thanks @cmcewen, my bad. I didn't find anything implementing that in React Native so I'm now bridging the Java example to RN. |
@martinvol FYI we have already forked the SMS retriever RN package so you can make your changes to our fork :) |
Expected Behavior
read both the country and phone number automatically, present both as a placeholder so the user can edit if incorrect.
If there are multiple phone numbers detected, present the default modal with options to prompt the user to select the correct one.
We use the Android hint picker so people don't have to type as much
https://developers.google.com/identity/sms-retriever/request (though apparently there are some bugs googlearchive/android-credentials#27)
Current Behavior
Everyone has to type
The text was updated successfully, but these errors were encountered: