[wallet] Added native phone picker #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvol
commented
Oct 11, 2019
jmrossy
reviewed
Oct 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
========================================
Coverage ? 74%
========================================
Files ? 283
Lines ? 7521
Branches ? 955
========================================
Hits ? 5566
Misses ? 1843
Partials ? 112
Continue to review full report at Codecov.
|
jmrossy
reviewed
Oct 18, 2019
martinvol
force-pushed
the
martinvol/wallet-automatic-country
branch
from
79cb972 to
fb7bcd6
Compare
…org/celo-monorepo into martinvol/wallet-automatic-country
martinvol
force-pushed
the
martinvol/wallet-automatic-country
branch
from
fb7bcd6 to
abdf441
Compare
…org/celo-monorepo into martinvol/wallet-automatic-country
jmrossy
reviewed
Nov 1, 2019
| @@ -3,12 +3,16 @@ import ValidatedTextInput, { | |||
| PhoneValidatorProps, | |||
| } from '@celo/react-components/components/ValidatedTextInput' | |||
| import colors from '@celo/react-components/styles/colors' | |||
| import SmsRetriever from '@celo/react-native-sms-retriever' | |||
There was a problem hiding this comment.
Have you confirmed that this doesn't break the verifier? Because it doesn't have this package set up so I assume the import would fail. Please run the verifier and double check the phone input screen is okay
…org/celo-monorepo into martinvol/wallet-automatic-country # Conflicts: # .circleci/config.yml
jmrossy
approved these changes
Nov 4, 2019
martinvol
force-pushed
the
martinvol/wallet-automatic-country
branch
from
82ca701 to
25e6680
Compare
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (73 commits) Fix Ethstats Image reference (#1577) EU Cookies Behavior Change (#1447) [verifier] Upgrade to RN 61 (#1572) [Wallet] Update link styles and Implement VerificationEducationScreen (#1565) [wallet] Added native phone picker (#1310) [Wallet] Set up new verification screen skeletons (#1563) Bump e2e test migrate numbers where needed (#1567) [Wallet] Create new carousel component (#1555) [Wallet] Protect Backup Key and Safeguards with PIN (#1556) Increase ganache gas limit (#1569) Re-work locked gold requirements for validators and groups (#1474) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JoinCeloscreen now request phone number + country code so that the user can select from there and not type.Tested
Other changes
packages/mobile/locales/en.jsonandpackages/mobile/locales/es.jsonUpgradedDone after upgrading to RN 61react-native-device-infoinverifierandwalletto get access togetBaseOS()Related issues
Backwards compatibility