Add MetadataURL to account struct #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-chrzan
reviewed
Sep 25, 2019
| @@ -87,6 +92,9 @@ contract Attestations is IAttestations, Ownable, Initializable, UsingRegistry, R | |||
|
|
|||
| // The ECDSA public key used to encrypt and decrypt data for this account | |||
| bytes dataEncryptionKey; | |||
|
|
|||
| // The URL under which an account add metadata and claims | |||
| @@ -16,12 +16,13 @@ interface IAttestations { | |||
|
|
|||
| // TODO: For some reason the compiler will complain about the next line | |||
| // function setAccountDataEncryptionKey(bytes) external; | |||
| // function setMetadataURL(string calldata) external; | |||
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
The compiler complained about non matching byte codee, same with setting the encryption key ...
| * @notice Setter for the metadata of an account. | ||
| * @param metadataURL The URL to access the metadata. | ||
| */ | ||
| function setMetadataURL(string memory metadataURL) public { |
There was a problem hiding this comment.
Doesn't look like this is being used anywhere else in the contract. Is this a requirement for every account and so should be set when creating one? If not, function should be external.
There was a problem hiding this comment.
Not every account, but external makes sense!
m-chrzan
approved these changes
Sep 25, 2019
…norepo into nambrot/identity-claims
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 256 256
Lines 7367 7367
Branches 427 491 +64
=======================================
Hits 4896 4896
+ Misses 2381 2379 -2
- Partials 90 92 +2
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Sep 25, 2019
* master: (61 commits) Remove locales as website is now just in English (#1050) Add MetadataURL to account struct (#1103) Allow validators to use any valid combination of gold commitments as stake (#885) Fix blockscout websocket jsonrpc url (#1096) [Wallet] Preliminary iOS support (#1098) [Wallet] Set security fee description translation in Spanish (#1097) Exclude generated in vscode file watcher setting (#1082) Update .env and .env.integration files (#1087) Allow a testnet to run without ethstats (#1085) Collect exchange rate time series using notification service (#1020) Return to preview view when Fee Education is closed (#1068) [Wallet] Pin Setup Flow v2 (#1054) Added a variable for electoral threshold (#1023) [celotool]Store .env config on GCS after deployment (#1086) Group size limit (#1035) Fix governance unit tests (#1084) Add getExchangeRate to ContractKit (#1083) [CLI]Unlock till the geth exits (#1070) Add Quorum and Refactor Governance (#430) Shuffle elected validators using block randomness (#1033) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for accounts to register a URL under which relevant metadata can live
Tested
Other changes
Added
setAccountDataEncryptionKeyin the interface.Related issues