Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up CircleCI tests #1333

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Speed up CircleCI tests #1333

merged 2 commits into from
Oct 15, 2019

Conversation

martinvol
Copy link
Contributor

Description

Moved things to build app while the emulator loads
Added GRADLE_OPTS to speed up build.

Tested

  • itself

Other changes

Changed some names to be more consistent

Related issues

Backwards compatibility

@martinvol martinvol marked this pull request as ready for review October 15, 2019 11:51
@martinvol martinvol requested a review from ashishb October 15, 2019 11:51
@martinvol martinvol changed the title Moved things to speed up Speed up CircleCI tests Oct 15, 2019
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1333   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files         264      264           
  Lines        7745     7745           
  Branches      444      513   +69     
=======================================
  Hits         5144     5144           
+ Misses       2502     2500    -2     
- Partials       99      101    +2
Flag Coverage Δ
#mobile 66.41% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/utils/formatting.ts 89.74% <0%> (ø) ⬆️
packages/mobile/src/identity/reducer.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b9cd2...074b268. Read the comment docs.

@martinvol martinvol assigned ashishb, jmrossy and cmcewen and unassigned ashishb Oct 15, 2019
@martinvol martinvol added the automerge Have PR merge automatically when checks pass label Oct 15, 2019
@ashishb ashishb merged commit a58d510 into master Oct 15, 2019
@ashishb ashishb deleted the martinvol/ci_mobile_speed_up branch October 15, 2019 14:20
if ! $ENABLE_EMULATOR_WINDOW ; then
PARAMS="${PARAMS} -no-window"
echo "Not showing emulator windown due ENABLE_EMULATOR_WINDOW env variable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in window. Also missing 'to' after due

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants