Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the e2e test script to make sure all previous servers are killed before starting a new one. #1340

Merged
merged 7 commits into from
Oct 30, 2019

Conversation

mojatalks
Copy link
Contributor

@mojatalks mojatalks commented Oct 15, 2019

Description

Updated the e2e test script to kill any previous server before starting a new test using react native killer.

Tested

Ran the mobile e2e test.

yarn test:dry-run-e2e

Other changes

N/A

Related issues

N/A - No issue was created. This was done during the mobile e2e testing overview as an exercise.

Backwards compatibility

N/A

@mojatalks mojatalks changed the title Judy/e2e fix Fix the e2e test script to make sure all previous servers are killed before starting a new one. Oct 16, 2019
@mojatalks mojatalks removed the request for review from cmcewen October 16, 2019 10:23
@mojatalks mojatalks self-assigned this Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #1340 into master will decrease coverage by 7.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   73.74%   66.43%   -7.31%     
==========================================
  Files         277      264      -13     
  Lines        7420     7744     +324     
  Branches      660      514     -146     
==========================================
- Hits         5472     5145     -327     
- Misses       1836     2497     +661     
+ Partials      112      102      -10
Flag Coverage Δ
#mobile 66.43% <ø> (-7.31%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/account/Analytics.tsx 0% <0%> (-100%) ⬇️
packages/mobile/src/account/Licenses.tsx 0% <0%> (-100%) ⬇️
packages/mobile/src/exchange/actions.ts 28.15% <0%> (-71.85%) ⬇️
packages/mobile/src/import/reducer.ts 37.5% <0%> (-18.06%) ⬇️
packages/mobile/src/firebase/firebase.ts 20.89% <0%> (-15.69%) ⬇️
packages/mobile/src/exchange/reducer.ts 60% <0%> (-15%) ⬇️
packages/mobile/src/alert/reducer.ts 60% <0%> (-12.73%) ⬇️
packages/mobile/src/backup/utils.ts 70.73% <0%> (-12.61%) ⬇️
packages/mobile/src/utils/dynamicLink.ts 64.7% <0%> (-12.22%) ⬇️
packages/mobile/src/networkInfo/reducer.ts 60% <0%> (-11.43%) ⬇️
... and 270 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a064908...bc11442. Read the comment docs.

Copy link
Contributor

@martinvol martinvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinvol martinvol added the automerge Have PR merge automatically when checks pass label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass e2e testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants