Support governance proposals/hotfixes in contractkit #1570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
force-pushed
the
yorhodes/contract-upgrades
branch
from
c7f18cf to
2e823a9
Compare
yorhodes
force-pushed
the
yorhodes/contract-upgrades
branch
from
744bfa5 to
9051b02
Compare
nambrot
reviewed
Nov 18, 2019
| } | ||
|
|
||
| type ProposalTxParams = Pick<ProposalTransaction, 'to' | 'value'> | ||
| export class ProposalBuilder { |
There was a problem hiding this comment.
I see that these two technically do two different things, but what do you think about merging ProposalUtility and ProposalBuilder?
| uint256 tally = 0; | ||
| uint256 n = numberValidatorsInCurrentSet(); | ||
| for (uint256 idx = 0; idx < n; idx++) { | ||
| address validator = validatorAddressFromCurrentSet(idx); | ||
| if (hotfixes[hash].whitelisted[validator]) { | ||
| if (isHotfixWhitelistedBy(hash, validator)) { |
There was a problem hiding this comment.
This might be off topic and I don't fully remember, but I believe the validator set contains the addresses of the validating keys, but is that the keys we expect validators to whitelist with? cc @asaj
There was a problem hiding this comment.
will fix in a followup PR
yorhodes
force-pushed
the
yorhodes/contract-upgrades
branch
from
dafede4 to
f0d5274
Compare
…des/contract-upgrades
yorhodes
force-pushed
the
yorhodes/contract-upgrades
branch
from
f0d5274 to
6f3c771
Compare
|
Closing for merge of #2139 |
This was referenced Mar 2, 2022
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds interfaces to
src/wrappers/Governancefor interacting with proposals/hotfixesAdds
src/governance/proposalsfor constructing proposal/hotfix inputsTested
Added
src/wrappers/Governance.testto test e2e proposal functionalityHotfix tests disabled until #1737 is fixed
Other changes
Adds
timeTraveltotest-utils/test-ganacheUpdates, simplifies, and dedupes type converters in
src/wrappers/BaseWrapperMigrates util functionality to
/packages/utils/src/addressAdds positional
argstosrc/explorer/block-explorer/CallDetailsinterface