-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify Solidity files #1623
Prettify Solidity files #1623
Conversation
@asaj I looked at the linked override at https://github.com/prettier-solidity/prettier-plugin-solidity#vscode, I wasn't sure if that's what we wanted, for example a width of 80 (instead of the 100) that we have been using. Both numbers seemed appropriate, so I kept 100 as it was less churn. Same with tabs/spaces, just kept the default |
+1 to sticking with our defaults here |
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
- Coverage 74.15% 73.86% -0.29%
==========================================
Files 287 283 -4
Lines 7652 7537 -115
Branches 960 954 -6
==========================================
- Hits 5674 5567 -107
+ Misses 1865 1858 -7
+ Partials 113 112 -1
Continue to review full report at Codecov.
|
Description
As a constant violator of the Solidity Style Guide (@asaj can attest to this fact), I told myself: "No more!". Hence this PR adds
prettier-solidity
which will prettify our.sol
files so that future generations shall no longer need to live in fear of style guide violations!It was actually incredibly easy, there was only 1 place where I needed to add a
// prettier-ignore
Tested
Backwards compatibility