[WIP] make page / baklava #1634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- leaderboard app with graphql fetch
|
@aaronmgdr @cmcewen @cla-bel This is only the top section with the leaderboard, not the subsequent sections with additional info. Also to be checked is the namespace. Shall everything go under |
…:diminator/celo-monorepo into diminator/great-celo-stakeoff-add-to-web
aaronmgdr
reviewed
Nov 8, 2019
| @@ -53,6 +55,7 @@ | |||
| "next-i18next": "^0.36.5", | |||
| "next-images": "^1.1.1", | |||
| "next-plugin-transpile-modules": "^2.0.0", | |||
| "node-fetch": "^2.6.0", | |||
There was a problem hiding this comment.
we have "cross-fetch" which can be used isomorphically
|
Hi its great that you implemented the fetching of data for leaderboard!. |
aaronmgdr
reviewed
Nov 8, 2019
| import { I18nProps, NameSpaces, withNamespaces } from 'src/i18n' | ||
|
|
||
| // TODO: check how to load this URL from env | ||
| const graphqlURI = getenv('REACT_APP_WS_GRAPHQL', 'http://localhost:8080/v1/graphql') |
There was a problem hiding this comment.
this can be placed in env-config file and loaded with with getConfig from next/config
aaronmgdr
reviewed
Nov 8, 2019
| animationKeyframes: [ | ||
| { | ||
| '0%': { | ||
| transform: 'scaleX(0)', |
clrblmt
assigned timmoreton, aaronmgdr, tjlahey and clrblmt and unassigned timmoreton and clrblmt
aaronmgdr
requested changes
Nov 14, 2019
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the leaderboard page for the great celo stake off according to wireframe
Tested
Upon loading:
Upon fetch error:
Other changes
REACT_APP_WS_GRAPHQLneeds to be passed to the app configRelated issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.