Add CLI command to activate votes #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## asaj/cli #1843 +/- ##
==========================================
Coverage ? 74.2%
==========================================
Files ? 278
Lines ? 7653
Branches ? 672
==========================================
Hits ? 5679
Misses ? 1857
Partials ? 117
Continue to review full report at Codecov.
|
nambrot
approved these changes
Nov 24, 2019
| } | ||
| } | ||
| const txos = await election.activate(account) | ||
| for (const txo of txos) { |
There was a problem hiding this comment.
Consider using concurrentMap here
There was a problem hiding this comment.
Per @mcortesi's recommendation, intentionally doing this serially.
| const accounts = await this.kit.contracts.getAccounts() | ||
| const account = await accounts.voteSignerToAccount(res.flags.from) | ||
| const txos = await election.revoke(account, res.flags.for, new BigNumber(res.flags.value)) | ||
| for (const txo of txos) { |
There was a problem hiding this comment.
Per @mcortesi's recommendation, intentionally doing this serially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a CLI command to activate any pending votes for an account, with the option to poll until the epoch is over and the votes can be activated.
Tested
Manually via against ganache.
Related issues
Backwards compatibility
Backwards compatible