Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation Bot POC #1851

Merged
merged 16 commits into from
Dec 3, 2019
Merged

Attestation Bot POC #1851

merged 16 commits into from
Dec 3, 2019

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Nov 25, 2019

Description

This PR creates a proof of concept for the attestation bot that automatically requests attestations.

Future changes (in the next PR right after this):

  • Pass through Twilio address config
  • Correctly read the forno provider
  • Actually fund this account properly with initial stabkeToken balance
  • suppress invalid signature error message
  • Select phone numbers from various countries
  • Recover from errors better when clearly the validator is not running the attestation service

Tested

  • Deployed on integration

Related issues

@nambrot nambrot changed the title Nambrot/attestation bot poc Attestation Bot POC Nov 25, 2019
@nambrot nambrot requested a review from timmoreton as a code owner November 25, 2019 07:40
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1851 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1851    +/-   ##
========================================
  Coverage   74.45%   74.45%            
========================================
  Files         281      281            
  Lines        7817     7817            
  Branches      685      973   +288     
========================================
  Hits         5820     5820            
  Misses       1880     1880            
  Partials      117      117
Flag Coverage Δ
#mobile 74.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0366984...d3c0391. Read the comment docs.

@nambrot nambrot added the automerge Have PR merge automatically when checks pass label Dec 2, 2019
@nambrot nambrot assigned nambrot and unassigned jmrossy Dec 2, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit c42e938 into master Dec 3, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the nambrot/attestation-bot-poc branch December 3, 2019 00:36
aaronmgdr added a commit that referenced this pull request Dec 3, 2019
* master:
  Update docker image and instructions (#2000)
  DOCS correct typos (#1965)
  Add a space on payment request (#1935)
  expose signer through getValidator (#1997)
  Fix validator election migration bug with sorted list insertion (#1998)
  Deploy an oracle cronjob (#1814)
  Set default env in attestation service docker image as production (#1999)
  Attestation Bot POC (#1851)
  Only allow external RPCs for tx nodes (#1994)
aaronmgdr added a commit that referenced this pull request Dec 4, 2019
* master: (120 commits)
  Update docker image and instructions (#2000)
  DOCS correct typos (#1965)
  Add a space on payment request (#1935)
  expose signer through getValidator (#1997)
  Fix validator election migration bug with sorted list insertion (#1998)
  Deploy an oracle cronjob (#1814)
  Set default env in attestation service docker image as production (#1999)
  Attestation Bot POC (#1851)
  Only allow external RPCs for tx nodes (#1994)
  Specify web deps properly (#1950)
  Fix error calculating fees on currencies with high exchange rate (#1937)
  Small pre-stake-off CLI cleanup (#1953)
  Migrations: different CLabs groups gets different votes (#1960)
  [Wallet] Fix broken translation (decline, pay) (#1968)
  [Wallet]: Add Payments You've Requested notifications group & screen (#1902)
  [Wallet] Fix iOS bundle script failing with our monorepo setup (#1958)
  [NotificationService] Change exchange rate stored format (number timestamp and pair) (#1945)
  [Wallet] Fix premature hiding of syncing banner and increase some timeouts (#1957)
  Avoid `liner: function not supported in this terminal` (#1955)
  Support more human readable log output (#1929)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants