-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gold and dollar flags are required for faucet script #1943
gold and dollar flags are required for faucet script #1943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asaj changed this to 0 recently (see git blame). We need to check with him before setting this back
I thought it was accidental, if not I'll go ahead and change the documentation. |
41bb5c5
to
363ddb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1943 +/- ##
==========================================
+ Coverage 74.43% 74.45% +0.02%
==========================================
Files 281 281
Lines 7822 7817 -5
Branches 974 685 -289
==========================================
- Hits 5822 5820 -2
+ Misses 1883 1880 -3
Partials 117 117
Continue to review full report at Codecov.
|
c932e2d
to
9f6bf83
Compare
a08a4ae
to
c1c85a4
Compare
c1c85a4
to
d49e2f3
Compare
* master: (27 commits) Experience Brand Kit 1.0 (#1948) Adjust reference to the rewards app (#2065) [Wallet] Compatibility with exchange rate in string format (#2060) Fix Typo in CI config (#2056) Fix additional attestations instructions (#2057) Allow a specified address to disable/enable rewards distribution (#1828) Aaronmgdr/leaderboard patch (#2055) Move attestation service instructions to main page (#2051) Point To Updated Join Celo Video (#2052) Fix minor issue withe the ordering of instructions changes to docs related to discovery (#2025) [Docs] Fix typos in Running a Validator docs (#2045) Add node flag to celocli to set the target node for a single command (#2020) Fix broken links and spruce up CLI docs for accounts command (#2027) Prevent clipping of arrow component (#2036) Allocates an initial balance to the attestation bot (#2019) gold and dollar flags are required for faucet script (#1943) Clean seed words text area when returns from empty wallet view (#1904) Update validator script (#2026) Docs: PoS, metadata, gateway fee plus cleanup (#2022) ...
Description
After merging #1844 the default value to faucet cUSD and cGLD was zero, now they are required and have no default.
Tested
Other changes
Changed logging, as it was printing the value in contract notation.
Related issues
Backwards compatibility
Nop