Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gold and dollar flags are required for faucet script #1943

Merged
merged 5 commits into from
Dec 4, 2019

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Nov 27, 2019

Description

After merging #1844 the default value to faucet cUSD and cGLD was zero, now they are required and have no default.

Tested

$ celotooljs account faucet --celo-env pilot --account 0xf601f32f6fee01ba148b4737d500a4991e7faa9b
celotooljs account faucet

command for fauceting an address with gold and/or dollar

Options:
  --version       Show version number                                                                                                                                   [boolean]
  --verbose       Whether to show a bunch of debugging output like stdout and stderr of shell commands                                                 [boolean] [default: false]
  --yesreally     Reply "yes" to prompts about changing staging/production (be careful!)                                                               [boolean] [default: false]
  --help          Show help                                                                                                                                             [boolean]
  --celo-env, -e  the environment in which you want to execute this command                                                                                            [required]
  --account       Account to faucet                                                                                                                           [string] [required]
  --dollar       Number of dollars to faucet                                                                                                                 [number] [required]
  --gold          Amount of gold to faucet                                                                                                                    [number] [required]

Missing required arguments: dollar, gold
Please specify dollars to faucet
Please specify gold to faucet
error Command failed with exit code 1.
$ celotooljs account faucet --celo-env pilot --account 0xf601f32f6fee01ba148b4737d500a4991e7faa9b --gold 10 --dollar 11
Port-forwarding to pilot validators 8545:8545 8546:8546 9200:9200
Port-forwarding to pilot validators 8545:8545 8546:8546 9200:9200


Using account: 0x387bCb16Bfcd37AccEcF5c9eB2938E30d3aB8BF2
Fauceting 10 Gold and 11 StableToken to 0xf601f32f6fee01ba148b4737d500a4991e7faa9b

Other changes

Changed logging, as it was printing the value in contract notation.

Related issues

Backwards compatibility

Nop

@martinvol martinvol requested a review from asaj November 27, 2019 14:22
@martinvol martinvol changed the title Faucet script now has a positive value Faucet script now has a positive value as default Nov 27, 2019
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asaj changed this to 0 recently (see git blame). We need to check with him before setting this back

@martinvol
Copy link
Contributor Author

I thought it was accidental, if not I'll go ahead and change the documentation.

@martinvol martinvol force-pushed the martinvol/changed_default_faucet_amount branch from 41bb5c5 to 363ddb4 Compare November 27, 2019 14:51
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #1943 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   74.43%   74.45%   +0.02%     
==========================================
  Files         281      281              
  Lines        7822     7817       -5     
  Branches      974      685     -289     
==========================================
- Hits         5822     5820       -2     
+ Misses       1883     1880       -3     
  Partials      117      117
Flag Coverage Δ
#mobile 74.45% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/import/ImportWalletEmpty.tsx 78.78% <0%> (-0.63%) ⬇️
packages/mobile/src/import/ImportWallet.tsx 95.83% <0%> (+5.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d0086...fb4503e. Read the comment docs.

@martinvol martinvol changed the title Faucet script now has a positive value as default gold and dollar flags are required for faucet script Dec 4, 2019
@martinvol martinvol requested a review from jmrossy December 4, 2019 01:35
@martinvol martinvol force-pushed the martinvol/changed_default_faucet_amount branch from c932e2d to 9f6bf83 Compare December 4, 2019 01:35
packages/celotool/src/cmds/account/faucet.ts Outdated Show resolved Hide resolved
@martinvol martinvol added the automerge Have PR merge automatically when checks pass label Dec 4, 2019
@martinvol martinvol force-pushed the martinvol/changed_default_faucet_amount branch 2 times, most recently from a08a4ae to c1c85a4 Compare December 4, 2019 01:50
@martinvol martinvol force-pushed the martinvol/changed_default_faucet_amount branch from c1c85a4 to d49e2f3 Compare December 4, 2019 01:51
@jmrossy jmrossy dismissed their stale review December 4, 2019 10:00

approved by asa

@celo-ci-bot-user celo-ci-bot-user merged commit fbc94ba into master Dec 4, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the martinvol/changed_default_faucet_amount branch December 4, 2019 15:44
aaronmgdr added a commit that referenced this pull request Dec 5, 2019
* master: (27 commits)
  Experience Brand Kit 1.0 (#1948)
  Adjust reference to the rewards app (#2065)
  [Wallet] Compatibility with exchange rate in string format (#2060)
  Fix Typo in CI config (#2056)
  Fix additional attestations instructions (#2057)
  Allow a specified address to disable/enable rewards distribution (#1828)
  Aaronmgdr/leaderboard patch (#2055)
  Move attestation service instructions to main page (#2051)
  Point To Updated Join Celo Video (#2052)
  Fix minor issue withe the ordering of instructions
  changes to docs related to discovery (#2025)
  [Docs] Fix typos in Running a Validator docs (#2045)
  Add node flag to celocli to set the target node for a single command (#2020)
  Fix broken links and spruce up CLI docs for accounts command (#2027)
  Prevent clipping of arrow component (#2036)
  Allocates an initial balance to the attestation bot (#2019)
  gold and dollar flags are required for faucet script (#1943)
  Clean seed words text area when returns from empty wallet view (#1904)
  Update validator script (#2026)
  Docs: PoS, metadata, gateway fee plus cleanup (#2022)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass celotool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants