WIP: Making Twilio the default provider in the attestation service #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmcewen/new script
…eth running in the attestation service node
nambrot
approved these changes
Dec 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
+ Coverage 74.42% 74.43% +<.01%
==========================================
Files 281 281
Lines 7824 7822 -2
Branches 975 974 -1
==========================================
- Hits 5823 5822 -1
+ Misses 1884 1883 -1
Partials 117 117
Continue to review full report at Codecov.
|
…o-monorepo into feature/making-twilio-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation and script running the attestation service is not using Twilio as default provider. This PR changes that.
Tested
Running locally
Other changes
Describe any minor or "drive-by" changes here.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.