Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removes sleep from commands #2102

Merged
merged 7 commits into from
Dec 6, 2019

Conversation

kobigurk
Copy link
Contributor

@kobigurk kobigurk commented Dec 6, 2019

Description

The sleep 1 prevents the infamous liner error. celo-org/celo-blockchain#703 adds it as part of the docker image.

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6571e8c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2102   +/-   ##
=========================================
  Coverage          ?   74.42%           
=========================================
  Files             ?      281           
  Lines             ?     7824           
  Branches          ?      687           
=========================================
  Hits              ?     5823           
  Misses            ?     1884           
  Partials          ?      117
Flag Coverage Δ
#mobile 74.42% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6571e8c...b719a07. Read the comment docs.

@asaj
Copy link
Contributor

asaj commented Dec 6, 2019

Looks so much cleaner using the default entrypoint!

@kobigurk kobigurk added the automerge Have PR merge automatically when checks pass label Dec 6, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit cc1f3ce into master Dec 6, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the kobigurk/remove_sleep_from_docs branch December 6, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants