Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an endpoint that can accept POST requests #2106

Merged
merged 3 commits into from
Dec 7, 2019

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Dec 6, 2019

Description

Twilio would complain that the specified endpoint does not actually accept POST requests. Since we just poll for messages anyways, I'm specifying an empty requestbin.com endpoint

Tested

  • Not tested

@nambrot nambrot added the automerge Have PR merge automatically when checks pass label Dec 6, 2019
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #2106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   74.87%   74.87%           
=======================================
  Files         281      281           
  Lines        7805     7805           
  Branches      686      686           
=======================================
  Hits         5844     5844           
  Misses       1845     1845           
  Partials      116      116
Flag Coverage Δ
#mobile 74.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b5336...934bd81. Read the comment docs.

@nategraf
Copy link
Contributor

nategraf commented Dec 6, 2019

What kind of post requests are these? Is there any risk of leaking security information?

@nategraf nategraf self-assigned this Dec 6, 2019
@nategraf nategraf assigned nambrot and unassigned nategraf Dec 6, 2019
@nambrot
Copy link
Contributor Author

nambrot commented Dec 6, 2019

They are the text messages requested by the attestation bot. With knowledge of the phone number and access to the requestbin, you could verify those phone numbers, but I'm not sure that that's any risk.

@nambrot nambrot assigned nategraf and unassigned nambrot Dec 6, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit f2db852 into master Dec 7, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the nambrot/suppress-attestation-bot-errors branch December 7, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants