Docs SBAT specify the correct proxy ip address and port #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2110 +/- ##
========================================
Coverage 74.87% 74.87%
========================================
Files 281 281
Lines 7805 7805
Branches 686 972 +286
========================================
Hits 5844 5844
Misses 1845 1845
Partials 116 116
Continue to review full report at Codecov.
|
kevjue
changed the title
kevjue
added
automerge
asaj
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to the docs so that it the proxy docker command will use the correct port forwarding rule and instruct to use the external ip address for the proxy.
Tested
Tested using an external validator and verified that it established the necessary number of peers.
Other changes
Related issues
Fixes: #2067
Backwards compatibility
Is backwards compatible.