[Wallet] Fix crash on iOS when segment is enabled #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
changed the title
jmrossy
approved these changes
Dec 12, 2019
celo-ci-bot-user
deleted the
jeanregisser/fix-crash-when-segment-enabled
branch
aaronmgdr
added a commit
that referenced
this pull request
Dec 12, 2019
* master: [Wallet] Use Charles proxy to see eth JSON rpc calls when using forno (#2204) [Wallet] Disable skip button when the user enable contact access (#2224) [Wallet] Redesigning notification lists (#1967) [Wallet] Fix crash on iOS when segment is enabled (#2222) Update documentation wrt. epoch rewards fractions (#2182) Improvement facilitating to run a full node (#2130) [BlockchainApi] Add ability to get exchange rates from/to cGLD or cUSD (#2005) Improve reliability of e2e governance test (#2208) Fix/protocol test flakyness (#2155) Fix bignumber display in CLI (#2212) Doc changes to address frequently asked questions (#2209) Upgrade TS version (#2196) Wait for only waitTime - 1 blocks (#2207) Minor baklava docs reconnection fixes (#2215) Update walletkit gateway fee to fix transactions in forno mode (#2211) Update baklava network ID in docs for 1.1 (#2214) Support more than 1 attesation bot at a time (#2192) Check sync status of attestation service (#2191) Indicate to run Twilio globally (#2193) Add Twilio and attestation bot envs (#2194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While preparing a TestFlight build I noticed the app was crashing on launch.
This was caused by
Segment-Firebasewhich tried to initialize Firebase when it had already been done.We didn't notice until now as we haven't created a new TestFlight build since Segment and React Native were upgraded. And Segment is not enabled in dev builds.
Fix was available upstream in
Segment-Firebase2.5.0 (segment-integrations/analytics-ios-integration-firebase#47) but requiredFirebase>= 6.2.Given the implications of switching to
Firebase6, I simply relaxed that requirement in the podspec (theSegment-Firebase2.5.0 update doesn't actually require new functionalities fromFirebase6.Note: we can revert this commit when we upgrade to
Firebase6Tested
App runs without crashing on launch.
Other changes
N/A
Related issues
Discussed on slack
Backwards compatibility
Yes