[Wallet] Use async support in react-native-tcp for connectIPC on Android #3099
Conversation
packages/mobile/package.json
Outdated
| @@ -115,7 +115,7 @@ | |||
| "react-native-splash-screen": "^3.2.0", | |||
| "react-native-svg": "^9.11.1", | |||
| "react-native-swiper": "^1.5.14", | |||
| "react-native-tcp": "https://github.com/cmcewen/react-native-tcp#65a1e45", | |||
| "react-native-tcp": "https://github.com/cmcewen/react-native-tcp#41caaa4", | |||
There was a problem hiding this comment.
Does the change correspond to this PR: valora-inc/react-native-tcp#5
If so, please get that merged to master on the RN-TCP repo before you use it here
There was a problem hiding this comment.
if that PR is ready for review I'll have a look :)
There was a problem hiding this comment.
I believe @cmcewen approved that PR but it can't hurt to get an extra look. Also I am online and available for a call/chat if you have any questions. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #3099 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 593 593
Lines 14849 14849
Branches 1485 1485
=======================================
Hits 11124 11124
Misses 3399 3399
Partials 326 326
Continue to review full report at Codecov.
|
jeanregisser
changed the title
Description
The goal of this PR is to make use of the version of react-native-tcp that has support for async networking to communicate with the unix socket exposed by geth.
Tested
yarn reset && yarn && cd packages/mobile && yarn dev:android
Made sure the app runs and using adb logcat looked for logs coming from the new version of react-native-tcp.
Other changes
None.
Related issues
Backwards compatibility
This change is backwards compatible.