[Wallet] Fix splash screen green gap #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
reviewed
Mar 13, 2020
| render() { | ||
| return ( | ||
| // @ts-ignore Apollo doesn't like the typings | ||
| <ApolloProvider client={apolloClient}> | ||
| <Provider store={store}> | ||
| <SafeAreaProvider> | ||
| <PersistGate | ||
| onBeforeLift={this.hideSplashScreen} |
There was a problem hiding this comment.
Can you test this an android too. I vaguely remember needing to add this onBeforeLift for android
There was a problem hiding this comment.
Yes works for Android too, I should have mentioned it ;)
Codecov Report
@@ Coverage Diff @@
## master #3105 +/- ##
==========================================
+ Coverage 74.79% 74.85% +0.05%
==========================================
Files 591 591
Lines 14794 14797 +3
Branches 1859 1790 -69
==========================================
+ Hits 11065 11076 +11
+ Misses 3403 3397 -6
+ Partials 326 324 -2
Continue to review full report at Codecov.
|
jmrossy
approved these changes
Mar 13, 2020
lucasege
pushed a commit
that referenced
this pull request
Mar 16, 2020
lucasege
pushed a commit
that referenced
this pull request
Mar 19, 2020
* Start of releasegold cli * Info cli command * Wip adding many more fns * Set max distribution fn * Unifying style and adding set-beneficiary * Addign withdraw and addressing various bugs introduced in cli deps * Adding more commands - gold, revoke, and refund * Adding final commands, still need to verify authorize and address todos. Also adding start_gold to script * Fxing ts weird bug * fixing type bug * Lint * Switching src to lib * Fixing cli bugs * Docs * Contractkit docs * WIP * Adding test framework for releasegold cli commands * Fixing flaky tests * Adding transfer * Fixing tests * Fixing jest timeout * lint * Lint and comments * wip * Small adjustments to migrations config (#2972) * Small adjustments to migrations config * More adjustments * updated based on comments * Fixed migration and testing around frozenGold and initialBalance, added addresses for governance approver, reserve spender, and whitelisted for transfers, changed frozenDays value to be in days rather than seconds * remove frozenGold since it requires reserve to have a balance greater than it, will require a governance proposal to initialize after the transfer of gold to reserve * bumped double signing slashing penalty to 9k * updates based on feedback * add more gas for e2e transfer tests that delete whitelist array * few more tweeks to migration config * fixed variable name MINUTE in config Co-authored-by: Amy Slawson <[email protected]> Co-authored-by: Amy Slawson <[email protected]> * [Wallet] Fix splash screen green gap (#3105) * Fix web build by changing literal to string (#3109) * Experience Brand kit updates (#3090) * Reducing boilerplate finished and adding better checks * Reverting cleanup * WIP on review * WIP review * Updating scripts to add functionality * Updating script * Addressign review, still flaky tests * Lint * Flaky * [Wallet] iOS multi env support + fastlane deployments (#3140) * Support multiple env file in Xcode Idea is one env file per scheme Addresses #1156 * Fix run_app script choking with env vars containing spaces * Add fastlane lanes for iOS alfajores and pilot * Fix incorrect link * Remove unused tvOS scheme * Fix e2e test * Rename generated config tmp.xcconfig -> env.xcconfig * Fix missing google service plist for CI build * Adding one more improvement * Removing unnecessary changes * lint Co-authored-by: Asa Oines <[email protected]> Co-authored-by: Amy Slawson <[email protected]> Co-authored-by: Amy Slawson <[email protected]> Co-authored-by: Jean Regisser <[email protected]> Co-authored-by: Connor McEwen <[email protected]> Co-authored-by: Aaron DeRuvo <[email protected]>
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed splash screen green gap (without Celo logo) by hiding it only after navigating away from the initial placeholder loading screen (AppLoading).
Tested
Tested on both iOS and Android.
before
after
Other changes
N/A
Related issues
Backwards compatibility
Yes.