-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReleaseGold various fixes and improvements #3153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3153 +/- ##
=======================================
Coverage 74.53% 74.53%
=======================================
Files 599 599
Lines 15014 15014
Branches 1886 1814 -72
=======================================
Hits 11191 11191
- Misses 3488 3490 +2
+ Partials 335 333 -2
Continue to review full report at Codecov.
|
asaj
approved these changes
Mar 20, 2020
…m:celo-org/celo-monorepo into lucasege/release-gold-pending-withdrawals
asaj
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes one crucial bug in RG where we don't account for pending withdrawal values, leaving the door open for potential early
selfdestruct
s and wonky releases.Also added various changes/ fixes detailed below.
Tested
Added unit testing for pending withdrawal accounting.
Other changes
Related issues
Backwards compatibility
Yes