Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReleaseGold various fixes and improvements #3153

Merged
merged 25 commits into from
Mar 26, 2020

Conversation

lucasege
Copy link
Contributor

Description

Fixes one crucial bug in RG where we don't account for pending withdrawal values, leaving the door open for potential early selfdestructs and wonky releases.

Also added various changes/ fixes detailed below.

Tested

Added unit testing for pending withdrawal accounting.

Other changes

  • Change deploy script to add months as multiples of 30 days rather than calendar months.
  • Use safemath everywhere in RG
  • Added events for self destruct events in RG

Related issues

Backwards compatibility

Yes

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3153 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3153   +/-   ##
=======================================
  Coverage   74.53%   74.53%           
=======================================
  Files         599      599           
  Lines       15014    15014           
  Branches     1886     1814   -72     
=======================================
  Hits        11191    11191           
- Misses       3488     3490    +2     
+ Partials      335      333    -2     
Flag Coverage Δ
#mobile 73.81% <ø> (ø)
#web 75.47% <ø> (ø)
Impacted Files Coverage Δ
packages/web/src/utils/utils.ts 79.62% <0.00%> (ø)
packages/web/src/utils/abortableFetch.ts 71.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94df42...8476afd. Read the comment docs.

@lucasege lucasege added the automerge Have PR merge automatically when checks pass label Mar 20, 2020
@lucasege lucasege removed the automerge Have PR merge automatically when checks pass label Mar 23, 2020
packages/protocol/contracts/governance/ReleaseGold.sol Outdated Show resolved Hide resolved
packages/protocol/lib/proxy-utils.ts Outdated Show resolved Hide resolved
@lucasege lucasege added the automerge Have PR merge automatically when checks pass label Mar 24, 2020
@lucasege lucasege merged commit cd022b3 into master Mar 26, 2020
@aaronmgdr aaronmgdr deleted the lucasege/release-gold-pending-withdrawals branch December 16, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing SafeMath addition in ReleaseGold Missing event logging in ReleaseGold
3 participants