Add PGPNP support to iOS #3765
Add PGPNP support to iOS #3765
Conversation
| "react-native-camera": "^3.23.1", | ||
| "react-native-clock-sync": "^1.0.0", | ||
| "react-native-config": "https://github.com/luggit/react-native-config#89a602b", | ||
| "react-native-confirm-device-credentials": "git://github.com/celo-org/react-native-confirm-device-credentials#436afa9", | ||
| "react-native-contacts": "https://github.com/celo-org/react-native-contacts#e473717", | ||
| "react-native-device-info": "^5.5.6", | ||
| "react-native-exit-app": "^1.1.0", | ||
| "react-native-fast-crypto": "git+https://github.com/celo-org/react-native-fast-crypto#3946f9", | ||
| "react-native-fast-crypto": "https://github.com/celo-org/react-native-fast-crypto#df1c171", |
There was a problem hiding this comment.
No logical changes to this package. I just merged the branch we were using there to master to make things easier to follow.
There was a problem hiding this comment.
I think react-native-bip39 also has a dep there which we should update. Feel like this is another argument to move things into the monorepo 😄
There was a problem hiding this comment.
Okay, fixed the reference in bip39
| "react-native-camera": "^3.23.1", | ||
| "react-native-clock-sync": "^1.0.0", | ||
| "react-native-config": "https://github.com/luggit/react-native-config#89a602b", | ||
| "react-native-confirm-device-credentials": "git://github.com/celo-org/react-native-confirm-device-credentials#436afa9", | ||
| "react-native-contacts": "https://github.com/celo-org/react-native-contacts#e473717", | ||
| "react-native-device-info": "^5.5.6", | ||
| "react-native-exit-app": "^1.1.0", | ||
| "react-native-fast-crypto": "git+https://github.com/celo-org/react-native-fast-crypto#3946f9", | ||
| "react-native-fast-crypto": "https://github.com/celo-org/react-native-fast-crypto#df1c171", |
There was a problem hiding this comment.
I think react-native-bip39 also has a dep there which we should update. Feel like this is another argument to move things into the monorepo 😄
| "dev:emulator": "bash ./scripts/start_emulator.sh &", | ||
| "dev:remote": "remotedev --hostname=localhost --port=8000", | ||
| "dev:emulator:list": "$ANDROID_HOME/emulator/emulator -list-avds", | ||
| "dev:emulator:run": "$ANDROID_HOME/emulator/emulator -avd", |
There was a problem hiding this comment.
I think if the functionality doesn't change it's nice to leave the name the same
There was a problem hiding this comment.
It was broken before so doubt anyone was using it. I prefer it like this
Codecov Report
@@ Coverage Diff @@
## master #3765 +/- ##
==========================================
- Coverage 75.88% 75.73% -0.16%
==========================================
Files 599 601 +2
Lines 15497 15547 +50
Branches 2012 2018 +6
==========================================
+ Hits 11760 11774 +14
- Misses 3375 3411 +36
Partials 362 362
Continue to review full report at Codecov.
|
…etriever app sig from the wallet instead of helm config
jmrossy
requested review from
asaj,
gastonponti,
mcortesi,
nambrot and
timmoreton
as code owners
Description
Tested
Retrieved salt on iOS
No regressions on Android.
Tested update to Att. service on Alfa Staging + Alfajores
Related issues
Backwards compatibility
Yes (feature still behind a feature flag)