Fixes crypto.Credentials deprecated error message #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were importing the entire crypto module which includes createCredentials and Credentials portions. We are not using them, but as they are being deprecated, we were still receiving the warning. To fix this, utils now directly imports the required functions from the crypto module and not the entire module.
medhakothari
pushed a commit
that referenced
this pull request
Jul 18, 2019
Pin mobile segment version to 1.2 since we are not ready for androidx
jmrossy
approved these changes
Jul 22, 2019
trianglesphere
deleted the
trianglesphere/crypto-credentials-deprecated-warning
branch
H34D
referenced
this pull request
in H34D/celo-monorepo
Nov 26, 2019
jcortejoso
pushed a commit
that referenced
this pull request
Jan 22, 2020
Celotool leaderboard fixes
barbaraliau
pushed a commit
to barbaraliau/celo-monorepo
that referenced
this pull request
Dec 11, 2020
fixed utils docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were importing the entire crypto module which includes
createCredentials and Credentials portions. We are not using them, but
as they are being deprecated, we were still receiving the warning.
To fix this, utils now directly imports the required functions from the
crypto module and not the entire module.
Tested
Tests in the utils package run. Unknown impact on the mobile phone package.
Backwards compatibility
Yes.