[Wallet] Make it easier to build and run the different envs #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Supports both debug/release for all envs (js bundle is generated for release builds) - Supports "dev" variants for day-to-day use, can be installed alongside the store apps - run_app.sh script can build iOS too and now launches the packager in a different terminal window respecting the user choice of terminal
Also tentative to make it work in release mode
jeanregisser
requested review from
asaj,
cmcewen,
i1skn,
jmrossy and
timmoreton
as code owners
jeanregisser
commented
Sep 25, 2020
gnardini
approved these changes
Oct 8, 2020
Yes, iOS e2e tests in release mode already works! |
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2020
### Description Following the switch to Android flavors in #5191, the mapping path became incorrect. ### Tested `bundle exec fastlane android alfajores` works. ### Related issues - Discussed on Slack ### Backwards compatibility Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it easier to build the app in the different envs we have.
.env.alfajores.env.alfajoresdev.env.mainnet.env.mainnetdev.env.testdebug/releasefor all envs (for release builds, the js bundle and assets are included in the app package)yarn dev:ios -e %envName%oryarn dev:android -e %envName%, (%envName%can bealfajores,alfajoresdev,mainnet,mainnetdevortest), add the-rflag to produce a release build which doesn't need the packager runningrun_app.shscript improvements:pilotandintegrationnetworkscelo-org-mobileFirebase project.Finally it is relatively simple to add new envs if needed.
Other changes
react-native-configTested
Successfully ran:
yarn dev:iosyarn dev:ios -e aflajoresdevyarn dev:ios -e aflajoresyarn dev:ios -e mainnetdevyarn dev:ios -e mainnetyarn dev:ios -ryarn dev:androidyarn dev:android -e aflajoresdevyarn dev:android -e aflajoresyarn dev:android -e mainnetdevyarn dev:android -e mainnetyarn dev:android -ryarn test:e2e:iosyarn test:e2e:ios -ryarn test:e2e:android(release mode (-r) option doesn't work yet as it fails at runtime due to proguard not keeping some Kotlin classes used by detox).bundle exec fastlane ios mainnet(though manually disabling upload)bundle exec fastlane android mainnet(though manually disabling upload)Related issues
Backwards compatibility
Yes