Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust governance end-to-end gold total supply block number #853

Merged
merged 8 commits into from
Sep 5, 2019

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Sep 4, 2019

Description

Adjust the block number at which we check the gold total supply in the governance end-to-end test in response to celo-org/celo-blockchain#423.

Tested

These are tests

Other changes

None

Related issues

@asaj asaj changed the base branch from asaj/https to master September 5, 2019 02:55
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files         243      243           
  Lines        7126     7126           
  Branches      464      399   -65     
=======================================
  Hits         4774     4774           
- Misses       2274     2276    +2     
+ Partials       78       76    -2
Flag Coverage Δ
#mobile 66.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/utils/formatting.ts 85.18% <0%> (ø) ⬆️
packages/mobile/src/identity/reducer.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6558a...115a318. Read the comment docs.

@asaj asaj merged commit 7082cb1 into master Sep 5, 2019
@timmoreton timmoreton assigned asaj and unassigned timmoreton and asaj Sep 5, 2019
aaronmgdr added a commit that referenced this pull request Sep 5, 2019
* master:
  Export geth metrics from StatefulSet tx-nodes and validators (#827)
  Adjust governance end-to-end gold total supply block number  (#853)
  [Blockchain API] Add currency conversion endpoint to blockchain api (#855)
  [Wallet] Fix Payment Requests and DRY up confirmation card code (#831)
  Use HTTPS instead of SSH for ethereumjs-vm (#850)
  Kill end-to-end celo-blockchain instances with SIGINT (#849)
  [CLI]Minor code improvement in CLI, remove ts-ignore-next-line (#796)
  [wallet] Always allow users to view backup key (#825)
  [contractkit] Complete Exchange Wrapper (#801)
  [Wallet] Fix web3 syncing sagas (#809)
  Aaronmgdr/social links connect (#792)
  Deploy integration (#806)
  [wallet] upgrade react-redux (#812)
@ashishb ashishb deleted the asaj/governance-e2e branch September 24, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants