Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feecurrency fixes #2

Merged
merged 9 commits into from
Oct 2, 2024
Merged

feecurrency fixes #2

merged 9 commits into from
Oct 2, 2024

Conversation

nicolasbrugneaux
Copy link
Contributor

No description provided.

@nicolasbrugneaux nicolasbrugneaux force-pushed the fix/feeCurrency-black-magic branch from 799d83b to 0289c23 Compare August 27, 2024 15:14
@nicolasbrugneaux nicolasbrugneaux changed the title wip: use data/value for feecurrency feecurrency fixes Sep 20, 2024
@nicolasbrugneaux
Copy link
Contributor Author

Note this won't work on CI yet as a change is still necessary in web3-eth
https://github.com/web3/web3.js/blob/4.x/packages/web3-eth/src/utils/prepare_transaction_for_signing.ts#L37-L56

This need to be more flexible

@socket-security Socket Security
Copy link

socket-security bot commented Oct 2, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None +7 4.77 MB mpetrunic
npm/[email protected] None +7 4.01 MB mpetrunic

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@nicolasbrugneaux
Copy link
Contributor Author

Since web3/web3.js#7282 was merged I updated the dependencies and this is in a workable state (locally), adjusting tests and github workflows.

@nicolasbrugneaux nicolasbrugneaux force-pushed the fix/feeCurrency-black-magic branch from c45b174 to c13041e Compare October 2, 2024 09:10
@nicolasbrugneaux nicolasbrugneaux force-pushed the fix/feeCurrency-black-magic branch from 2b961e3 to b2f01d2 Compare October 2, 2024 09:28
@nicolasbrugneaux nicolasbrugneaux force-pushed the fix/feeCurrency-black-magic branch from 55dae7f to b2f01d2 Compare October 2, 2024 09:38
@nicolasbrugneaux nicolasbrugneaux merged commit c9fee6d into main Oct 2, 2024
4 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicolasbrugneaux