-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes (most) -Wall and -Wextra warnings #93
Conversation
hmm and I'm still getting -Werror leaking in downstream projects, investigating why... |
Doesn't fix cmidi2.hpp since that's external. Signed-off-by: Gabe Gonzalez II <[email protected]>
Mostly more of the same of the previous commit. Also removes a few missed checks for LIBREMIDI_HAS_SPAN since C++20 is the minimum now. Signed-off-by: Gabe Gonzalez II <[email protected]>
… the user are not going to break the build
2b766c0
to
dc383e0
Compare
okay, problems can come up if the user has some additional warnings - e.g. I have -Wnon-virtual-dtor in a downstream project as CMAKE_CXX_FLAGS and thus this breaks the build. I'm going to enable Werror only during CI this way it won't break randomly for users. |
I think I may have figured out why the warnings are leaking through downstream. I think it might be this in the cmake file
Specifically, I think before |
The other |
@lilggamegenius there were a lot of build errors with the PR actually ^^' let's put the work to fix them here