Latte code clean up + Proper support for SAMPLE_LB shader instruction #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super Mario 3D World crashes on opening. |
|
Thanks for letting me know. It crashes on my end too, I'll look into it |
|
d2ba4e6 should fix it. |
|
Confirmed. The game is working again, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly for cleaning up old OpenGL mannerisms in the shared renderer code. While doing this I noticed that the SAMPLE_LB shader instruction was never correctly implemented so I added that now. The only shaders that I could find which use this instruction are the terrain shaders in BotW. But I couldn't really see a visual difference after the fix.
Also for OpenGL we now have some wrappers to emulate DSA-style API even if the driver doesn't provide the actual extension. This simplifies the GL renderer code a bit since we don't have to worry about altering the render state when creating or updating textures