Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DrLuigi] Fix undefined shader behavior, merge AA mod into graphics mod #664

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

intra0
Copy link
Contributor

@intra0 intra0 commented Dec 14, 2024

Updates the dr luigi packs to v6
and moves them into src
merges AA scaling and disabling into one mod

@intra0
Copy link
Contributor Author

intra0 commented Dec 14, 2024

Sorry to @you again @ActualMandM but you made these mods in commit 1e84898
I noticed that the resolution pack and the anti aliasing pack both use the same shader?

is there a reason they are separate mods or?

@ActualMandM
Copy link
Contributor

i think the anti aliasing shader is broken in that repo? best to do it from scratch

@intra0
Copy link
Contributor Author

intra0 commented Dec 14, 2024

Tested the AA pack and it does work. Will get screen shots tomorrow

So I assume I would just remove the AA shader from the gfx pack then?

@Crementif
Copy link
Member

Crementif commented Dec 14, 2024

No, we'd want to prioritize having working scaling over being able to disable the anti-aliasing. I'm not sure if that's been done before, judging by M&M's comment. You should merge the anti-aliasing setting into the Graphics graphic pack preferably, otherwise there's no benefit to using v6 instead of just not bothering to update these graphic packs and breaking compatibility.

@intra0
Copy link
Contributor Author

intra0 commented Dec 14, 2024

Just figured out how to merge them @Crementif

ran a diff compare, got:

76c71
< R0i = floatBitsToInt(passParameterSem129);
---
> //R0i = floatBitsToInt(passParameterSem129);
80,84d74
< 
< ivec2 resolution = textureSize(textureUnitPS0,0);
< float iresX = float(resolution.x)/float(1280);
< float iresY = float(resolution.y)/float(720);
< 
89c79
< PV0i.y = floatBitsToInt(intBitsToFloat(backupReg0i) / iresY);
---
> PV0i.y = floatBitsToInt(intBitsToFloat(backupReg0i) * 1.0);
91c81
< R127i.w = floatBitsToInt(intBitsToFloat(backupReg1i) / iresX);
---
> R127i.w = floatBitsToInt(intBitsToFloat(backupReg1i) * 1.0);

and have used #if #endif statements to merge the changes

Accidentially forgot to rename the shader file back to what it was
so there were 2 shader files, one incorrectly named, and the correctly named one with no changes
version = 4
name = Graphics Settings
path = "Dr. Luigi/Graphics"
description = Changes the resolution of the game and Enable/Disable the game's Anti-Aliasing.|Made by M&&M.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the description could be better?
maybe its fine enough though

required for the mod to work
@intra0
Copy link
Contributor Author

intra0 commented Dec 14, 2024

Screenshots:
(you can see the difference most clearly on the virus monsters)
(and the border around the falling pills is a cemu issue, happens even when no gfx are enabled)

new Dr luigi pack with AA enabled at 1440p
Screenshot_2024-11-10_20-12-06

new Dr luigi pack with AA disabled at 1440p
Screenshot_2024-11-10_20-09-12

@intra0 intra0 changed the title [DrLuigi] update to v6, and move into src [DrLuigi] Fix undefined shader behavior, merge AA mod into graphics mod Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants