-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DrLuigi] Fix undefined shader behavior, merge AA mod into graphics mod #664
base: master
Are you sure you want to change the base?
Conversation
Sorry to @you again @ActualMandM but you made these mods in commit 1e84898 is there a reason they are separate mods or? |
i think the anti aliasing shader is broken in that repo? best to do it from scratch |
Tested the AA pack and it does work. Will get screen shots tomorrow So I assume I would just remove the AA shader from the gfx pack then? |
No, we'd want to prioritize having working scaling over being able to disable the anti-aliasing. I'm not sure if that's been done before, judging by M&M's comment. You should merge the anti-aliasing setting into the Graphics graphic pack preferably, otherwise there's no benefit to using v6 instead of just not bothering to update these graphic packs and breaking compatibility. |
Just figured out how to merge them @Crementif ran a diff compare, got:
and have used #if #endif statements to merge the changes |
version = 4 | ||
name = Graphics Settings | ||
path = "Dr. Luigi/Graphics" | ||
description = Changes the resolution of the game and Enable/Disable the game's Anti-Aliasing.|Made by M&&M. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the description could be better?
maybe its fine enough though
required for the mod to work
Updates the dr luigi packs to v6
and moves them into src
merges AA scaling and disabling into one mod