This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fix Windows builds with appveyor #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@g-easy @bogdandrutu As far as I can tell, this is complete. Is it really neccessary with Bazel build? Could that be done in another PR? |
|
I thought it was gonna be easier with bazel. :^) How about this:
|
g-easy
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP, ref #289
I'm not familiar at all with bazel builds, so I'm starting with CMake. That's also an incentive to expand the CMake support ;)
It looks like appveyor has support for
vcpkgas well, so it could be used to test a future vcpkg-build of opencensus with find_package for dependencies :)That said, supporting both is an option: https://github.com/google/googletest/blob/master/appveyor.yml