Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Move go.opencensus.io/exportutil to go.opencensus.io/export #779

Closed
rakyll opened this issue Jun 5, 2018 · 0 comments
Closed

Move go.opencensus.io/exportutil to go.opencensus.io/export #779

rakyll opened this issue Jun 5, 2018 · 0 comments

Comments

@rakyll
Copy link
Contributor

rakyll commented Jun 5, 2018

There is no export package. We can instead put the Version under export package.

OTHO, we should make Version an accessor, it is immutable.

func Version() string

/cc @Ramonza

rakyll added a commit to rakyll/opencensus-go that referenced this issue Jun 6, 2018
Version returns the OpenCensus library version. It is not an exporter utility.
If it is an exporter utility, it shouldnt be in exportutil. In Go, utility packages
are organized under an existing package.

For example, io/iotuil or net/http/httputil.

Fixes census-instrumentation#779.
rakyll added a commit that referenced this issue Jun 6, 2018
Version returns the OpenCensus library version. It is not an exporter utility.
If it is an exporter utility, it shouldnt be in exportutil. In Go, utility packages
are organized under an existing package.

For example, io/iotuil or net/http/httputil.

Fixes #779.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant