This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Exemplar: Restore previous package to avoid breaking downstream. #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
commented
Mar 19, 2019
| // Their purpose it to provide an example of the kind of thing | ||
| // (request, RPC, trace span, etc.) that resulted in that measurement. | ||
| // | ||
| // Deprecated: Use go.opencensus.io/metric/metricdata instead. |
There was a problem hiding this comment.
Please import go.opencensus.io/metric/metricdata for migration.
This was referenced Mar 19, 2019
|
Is the goal here to simply not break the downstream builds? None of the content is actually used in the core library. |
Yes, if downstream always depends on mainline and imports "go.opencensus.io/exemplar", the previous PR will break their build. Per https://github.com/census-instrumentation/opencensus-go#deprecation-policy we should leave time for downstream to update their dependencies. |
rghetia
approved these changes
Mar 19, 2019
songy23
added a commit
that referenced
this pull request
Apr 3, 2019
(cherry picked from commit ebb7978)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only restored minimal files and marked them as deprecated.