This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 329
stats worker as metric producer. #1078
Merged
rghetia
merged 4 commits into
census-instrumentation:master
from
rghetia:view_as_metric_producer
Mar 27, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3a14ecd
stats worker as metric producer.
rghetia 5bda759
fixed the conversion based on measure type in addition to aggregation…
rghetia 6054b9f
fixed review comments related to count float64.
rghetia 6d19433
add check for metricType in toPoint func for distribution
rghetia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
// Copyright 2019, OpenCensus Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
|
||
package view | ||
|
||
import ( | ||
"time" | ||
|
||
"go.opencensus.io/metric/metricdata" | ||
"go.opencensus.io/stats" | ||
) | ||
|
||
func getUnit(unit string) metricdata.Unit { | ||
switch unit { | ||
case "1": | ||
return metricdata.UnitDimensionless | ||
case "ms": | ||
return metricdata.UnitMilliseconds | ||
case "By": | ||
return metricdata.UnitBytes | ||
} | ||
return metricdata.UnitDimensionless | ||
} | ||
|
||
func getType(v *View) metricdata.Type { | ||
m := v.Measure | ||
agg := v.Aggregation | ||
|
||
switch agg.Type { | ||
case AggTypeSum: | ||
switch m.(type) { | ||
case *stats.Int64Measure: | ||
return metricdata.TypeCumulativeInt64 | ||
case *stats.Float64Measure: | ||
return metricdata.TypeCumulativeFloat64 | ||
default: | ||
panic("unexpected measure type") | ||
} | ||
case AggTypeDistribution: | ||
return metricdata.TypeCumulativeDistribution | ||
case AggTypeLastValue: | ||
switch m.(type) { | ||
case *stats.Int64Measure: | ||
return metricdata.TypeGaugeInt64 | ||
case *stats.Float64Measure: | ||
return metricdata.TypeGaugeFloat64 | ||
default: | ||
panic("unexpected measure type") | ||
} | ||
case AggTypeCount: | ||
switch m.(type) { | ||
songy23 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
case *stats.Int64Measure: | ||
return metricdata.TypeCumulativeInt64 | ||
case *stats.Float64Measure: | ||
return metricdata.TypeCumulativeInt64 | ||
default: | ||
panic("unexpected measure type") | ||
} | ||
default: | ||
panic("unexpected aggregation type") | ||
} | ||
} | ||
|
||
func getLableKeys(v *View) []string { | ||
labelKeys := []string{} | ||
for _, k := range v.TagKeys { | ||
labelKeys = append(labelKeys, k.Name()) | ||
} | ||
return labelKeys | ||
} | ||
|
||
func viewToMetricDescriptor(v *View) *metricdata.Descriptor { | ||
return &metricdata.Descriptor{ | ||
Name: v.Name, | ||
Description: v.Description, | ||
Unit: getUnit(v.Measure.Unit()), | ||
Type: getType(v), | ||
LabelKeys: getLableKeys(v), | ||
} | ||
} | ||
|
||
func toLabelValues(row *Row) []metricdata.LabelValue { | ||
labelValues := []metricdata.LabelValue{} | ||
for _, tag := range row.Tags { | ||
labelValues = append(labelValues, metricdata.NewLabelValue(tag.Value)) | ||
songy23 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
return labelValues | ||
} | ||
|
||
func rowToTimeseries(v *viewInternal, row *Row, now time.Time, startTime time.Time) *metricdata.TimeSeries { | ||
return &metricdata.TimeSeries{ | ||
Points: []metricdata.Point{row.Data.toPoint(v.metricDescriptor.Type, now)}, | ||
LabelValues: toLabelValues(row), | ||
StartTime: startTime, | ||
songy23 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
func viewToMetric(v *viewInternal, now time.Time, startTime time.Time) *metricdata.Metric { | ||
if v.metricDescriptor.Type == metricdata.TypeGaugeInt64 || | ||
v.metricDescriptor.Type == metricdata.TypeGaugeFloat64 { | ||
startTime = time.Time{} | ||
songy23 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
rows := v.collectedRows() | ||
if len(rows) == 0 { | ||
return nil | ||
} | ||
|
||
ts := []*metricdata.TimeSeries{} | ||
for _, row := range rows { | ||
ts = append(ts, rowToTimeseries(v, row, now, startTime)) | ||
} | ||
|
||
m := &metricdata.Metric{ | ||
Descriptor: *v.metricDescriptor, | ||
TimeSeries: ts, | ||
} | ||
return m | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why convert all other units to "1"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open a new PR to fix this.