-
Notifications
You must be signed in to change notification settings - Fork 329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
after vanity-url PR is merged I can replace with new dependencies in examples |
Agree, I'll hold off this PR until examples are updated. Or we can move the exporter-specific examples to exporter repos. |
The problem with moving examples to exporter repo is that most of the example related to core functionality will move to prometheus just because we use prometheus in most (if not all) examples. @bogdandrutu, should we create example repo and simply link it in readme.md in core library? |
Probably we can have in each exporter repo it's own example. |
That would require that we repeat feature examples (like gauge) in all exporters. |
63efc11
to
50000d0
Compare
Rebased against the latest |
If anyone lands here wondering where they were moved to: https://github.com/census-ecosystem (with imports as |
This results in a better fix for the missing thrift repo on apache. The thrift version was required by opencensus but since oc factored the exporters out of the main package, this thrift dependency is no longer required. census-instrumentation/opencensus-go#1118 Incidently this also makes usage of go-sundheit easier for other libs as they don't need to work around the apache thrift issue themselves anymore
Also run
$ GO111MODULE=on go mod tidy
.