This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Update LRU usage #1164
Merged
Update LRU usage #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaseaton
requested review from
rakyll,
rghetia and
a team
as code owners
|
I'm seeing continuous-integration/appveyor/pr checks fail with Windows |
yes, it is a known issue. |
rghetia
reviewed
Sep 4, 2019
This change updates the LRU cache implementation used in the trace package, replacing github.com/hashicorp/golang-lru with github.com/golang/groupcache, while preserving the manner in which trace abstractions make use of the data structure. The reason for this change is that github.com/hashicorp/golang-lru has a Mozilla license, which is different from that of github.com/census-instrumentation/opencensus-go. The difference (and the mere presence of the former) makes it more difficult for open-source projects (e.g., https://fuchsia.dev) to vendor the latter.
rghetia
approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the LRU cache implementation used in the trace
package, replacing github.com/hashicorp/golang-lru with
github.com/golang/groupcache, while preserving the manner in which trace
abstractions make use of the data structure.
The reason for this change is that github.com/hashicorp/golang-lru has a
Mozilla license, which is different from that of
github.com/census-instrumentation/opencensus-go. The difference (and the
mere presence of the former) makes it more difficult for open-source
projects (e.g., https://fuchsia.dev) to vendor the latter.